Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker]Fix the description #3869

Merged
merged 1 commit into from
May 10, 2021
Merged

[image_picker]Fix the description #3869

merged 1 commit into from
May 10, 2021

Conversation

ydag
Copy link
Contributor

@ydag ydag commented May 10, 2021 •
edited
Loading

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ydag ydag requested a review from cyanglaz as a code owner May 10, 2021 12:55
@google-cla google-cla bot added the cla: yes label May 10, 2021
mvanbeusekom
mvanbeusekom approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom merged commit 6f8bb67 into flutter:master May 10, 2021
@mvanbeusekom mvanbeusekom deleted the image_picker_fix_description branch May 10, 2021 14:13
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
e4ee667
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
25df367
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
7b2365d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
444a27f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
3a45fb2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
7840e1d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
7efc047
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
dc8f9b3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
d7d58c0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
a46862c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
a6fd9f6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
dec7e7f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
c143d63
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
ca4473b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
a16afb8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
fb272a3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
6f8bb67 Fix the description (flutter/plugins#3869)
60e4c7c
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@ydag @fotiDim
Fix the description (flutter#3869)
fbb2293
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
cla: yes p: image_picker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ydag @mvanbeusekom @stuartmorgan