Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] iOS example using in_app_purchase_ios package #3870

Merged
merged 38 commits into from
May 12, 2021

Conversation

mvanbeusekom
Copy link
Contributor

@mvanbeusekom mvanbeusekom commented May 10, 2021

Adds the example app for the in_app_purchase_ios platform implementation.

All files that are part of the in_app_purcase_ios/example/ios folder have been copied over from in_app_purchase/example/ios. From all these files I only had to update the following:

  1. Renamed in_app_purchase_ios/ios/in_app_purchase.podspec file to in_app_purchase_ios/ios/in_app_purchase_ios.podspec (to match the new package name);
  2. Update the @import in_app_purchase statement to @import in_app_purchase_ios in the following files:
    • InAppPurchasePluginTest.m
    • PaymentQueueTest.m
    • ProductRequestHandlerTest.m
    • Stubs.h
    • TranslatorTest.m

I have tested the example project on my iPhone 12 Mini and it works fine. Also the iOS specific unit-test run correctly.

Adds the iOS implementation for issue flutter/flutter#81695

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

dependencies:
flutter:
sdk: flutter
shared_preferences: ^2.0.0-nullsafety.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^2.0.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


# TODO(mvanbeusekom): Replace with pub.dev version when in_app_purchase_platform_interface is published
in_app_purchase_platform_interface:
path: ../../in_app_purchase_platform_interface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace with 1.0.0 as the platform interface has published

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz merged commit e88b1d8 into flutter:master May 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
…ter#3870)

Adds the example app for the in_app_purchase_ios platform implementation.

All files that are part of the in_app_purcase_ios/example/ios folder have been copied over from in_app_purchase/example/ios. From all these files I only had to update the following:

Renamed in_app_purchase_ios/ios/in_app_purchase.podspec file to in_app_purchase_ios/ios/in_app_purchase_ios.podspec (to match the new package name);
Update the @import in_app_purchase statement to @import in_app_purchase_ios in the following files:
InAppPurchasePluginTest.m
PaymentQueueTest.m
ProductRequestHandlerTest.m
Stubs.h
TranslatorTest.m
I have tested the example project on my iPhone 12 Mini and it works fine. Also the iOS specific unit-test run correctly.

Adds the iOS implementation for issue flutter/flutter#81695
@mvanbeusekom mvanbeusekom deleted the ios_example branch September 21, 2021 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants