Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[video_player][camera] fix video_player camera tests #3892

Merged
merged 1 commit into from
May 14, 2021

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented May 14, 2021

Use TestWidgetsFlutterBinding.ensureInitialized(); to make sure necessary resources are initliazed.

This partially fix the currently broken CI.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz
Copy link
Contributor Author

Landing on red to partially fix the tree. This should result only url_launcher failure on ToT.

@cyanglaz cyanglaz merged commit d0a9aea into flutter:master May 14, 2021
@cyanglaz cyanglaz deleted the fix_tests branch May 14, 2021 19:25
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
…itialized(); to make sure necessary resources are initialized. (flutter/plugins#3892)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
…itialized(); to make sure necessary resources are initialized. (flutter/plugins#3892)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
…itialized(); to make sure necessary resources are initialized. (flutter/plugins#3892)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
…d(); to make sure necessary resources are initialized. (flutter#3892)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants