This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Bump min Android SDK to the version required at runtime #3894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p: google_maps_flutter
p: webview_flutter
added 3 commits
May 14, 2021 16:30
cyanglaz
approved these changes
May 15, 2021
| @@ -79,7 +79,13 @@ class CreateAllPluginsAppCommand extends PluginCommand { | |||
|
|
|||
| final StringBuffer newGradle = StringBuffer(); | |||
| for (final String line in gradleFile.readAsLinesSync()) { | |||
| newGradle.writeln(line); | |||
| if (line.contains('minSdkVersion 16')) { | |||
There was a problem hiding this comment.
Since we are creating "all plugins", which def contains google maps and web views, should we just never allow minSdkVersion to 16?
There was a problem hiding this comment.
In the test? Yup, this line changes the minSdkVersion. For all Flutter, see flutter/flutter#82000
blasten
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2021
daohoangson
added a commit
to daohoangson/flutter_widget_from_html
that referenced
this pull request
May 21, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Maps requires Android SDK 20 until it's migrated to hybrid composition.
Webview requires Android SDK 19 when hybrid composition is used.
Pre-launch Checklist
dart format. See plugin_tool format)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.