This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Mass pubspec.yaml cleanup #3927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
requested review from
bparrishMines,
cyanglaz,
ditman,
gaaclarke and
LHLL
as code owners
github-actions
bot
added
p: camera
p: espresso
p: file_selector
p: flutter_plugin_android_lifecycle
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: in_app_purchase
p: ios_platform_images
p: local_auth
p: path_provider
p: plugin_platform_interface
p: quick_actions
p: shared_preferences
p: url_launcher
p: video_player
p: webview_flutter
ditman
approved these changes
May 19, 2021
There was a problem hiding this comment.
It seems you got the pubspecs to a common standardized format (environment, flutter, deps, dev_deps) and sorted dependencies alphabetically...
Is there a lint to keep the pubspec.yaml files this clean after this is merged? Or should we keep an eye out during PRs?
|
(Never mind, I've just seen your note)
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 21, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
Regularizes the pubspec.yaml files of the plugins: - Changes from `homepage` to `repository` to improve the linking on pub.dev. - Adds an `issue_tracker` link that links directly to a search on that plugin's label, to improve the linking on pub.dev. - Standardizes the section order as `environment`, `flutter`, `dependencies`, `dev_dependencies`. This matches the current template, except that `flutter` is higher as it's critical information in a plugin (which should potentially be revisited in the template). - Sorts dependencies within each section. - Updates the Flutter SDK versions to 2.0.0; in practice this is already the case due to the Dart SDK version requirement, so this just makes it less confusing. - Standardizes the location of `version` in the initial block. Changes that were considered out of scope: - Actually cleaning up dependencies (e.g., removing meta where it's no longer needed). The goal was to make this PR as mechanical as possible, and to not change any actual behavior). - The example/ pubspecs (just to limit the scope of the PR; we should eventually clean those up too). - Plugins that have Plus Plugin equivalents, per repo policy, as this is a non-critical change. This does not update versions; these changes can be picked up the next time the plugins happen to be published. This also doesn't add automated enforcement. We should consider that in the future though; filed as flutter/flutter#82913
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regularizes the pubspec.yaml files of the plugins:
homepagetorepositoryto improve the linking on pub.dev.issue_trackerlink that links directly to a search on that plugin's label, to improve the linking on pub.dev.environment,flutter,dependencies,dev_dependencies. This matches the current template, except thatflutteris higher as it's critical information in a plugin (which should potentially be revisited in the template).versionin the initial block.Changes that were considered out of scope:
This does not update versions; these changes can be picked up the next time the plugins happen to be published.
This also doesn't add automated enforcement. We should consider that in the future though; filed as flutter/flutter#82913
Pre-launch Checklist
dart format. See plugin_tool format)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.