Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] and [url_launcher_platform_interface] Fix tests broken my ChannelBuffers migration #3966

Merged
merged 2 commits into from
May 22, 2021

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented May 22, 2021

Combines #3965 and #3963:

  • This test broke because it relies on implementation details that are no longer valid. We believe it is redundant with the test above it and the test in the interface package at this point.
  • ChannelBuffers is actually async so we have to run the test using runAsync otherwise the future will never complete.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Hixie added 2 commits May 21, 2021 19:15
This test broke because it relies on implementation details that are no longer valid. We believe it is redundant with the test above it and the test in the interface package at this point.
...so we have to run the test using runAsync otherwise the future will never complete.
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan
Copy link
Contributor

Landing on red to fix the tree.

@stuartmorgan stuartmorgan merged commit bca7c9f into flutter:master May 22, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2021
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request May 22, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
… my ChannelBuffers migration (flutter#3966)

* Remove redundant test.

This test broke because it relies on implementation details that are no longer valid. We believe it is redundant with the test above it and the test in the interface package at this point.

* ChannelBuffers is actually async

...so we have to run the test using runAsync otherwise the future will never complete.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants