Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[quick-actions] Revert migrating integration tests to NNBD #3967

Merged
merged 1 commit into from
May 24, 2021
Merged

[quick-actions] Revert migrating integration tests to NNBD #3967

merged 1 commit into from
May 24, 2021

Conversation

stuartmorgan
Copy link
Contributor

Reverts the quick_action portion of:
"Move integration test to null safety for multiple plugins (#3932)"
(commit a864de2) since it seems to have
broken XCUITests.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@stuartmorgan
[quick-actions] Revert migrating integration tests to NNBD
f447224 
Reverts the quick_action portion of:
"Move integration test to null safety for multiple plugins (flutter#3932)"
(commit a864de2) since it seems to have
broken XCUITests.
@google-cla google-cla bot added the cla: yes label May 22, 2021
mvanbeusekom
mvanbeusekom approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan
Copy link
Contributor Author

Landing on red to fix tree.

@stuartmorgan stuartmorgan merged commit 52033ca into flutter:master May 24, 2021
@stuartmorgan stuartmorgan deleted the revert-quick-actions-nnbd-integration-tests branch May 24, 2021 15:11
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 24, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 24, 2021
@engine-flutter-autoroll
52033ca [quick-actions] Revert migrating integration tests to NNBD (f…
8e48d89 
…lutter/plugins#3967)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 24, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 24, 2021
@engine-flutter-autoroll
52033ca [quick-actions] Revert migrating integration tests to NNBD (f…
1f4014a 
…lutter/plugins#3967)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan @fotiDim
[quick-actions] Revert migrating integration tests to NNBD (flutter#3967
d3db6e3 
)

Reverts the quick_action portion of:
"Move integration test to null safety for multiple plugins (flutter#3932)"
(commit a864de2) since it seems to have
broken XCUITests.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

@blasten blasten Awaiting requested review from blasten

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
cla: yes p: quick_actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan @mvanbeusekom