This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[camera] android-rework part 7: Android noise reduction feature #4052
Merged
fluttergithubbot
merged 5 commits into
flutter:master
from
Baseflow:camera-android/noise_reduction_feature
Jun 22, 2021
Merged
[camera] android-rework part 7: Android noise reduction feature #4052
fluttergithubbot
merged 5 commits into
flutter:master
from
Baseflow:camera-android/noise_reduction_feature
Jun 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvanbeusekom
suggested changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just needs documentation for two public methods. Also the format
step in tree seems to be failing.
...d/src/main/java/io/flutter/plugins/camera/features/noisereduction/NoiseReductionFeature.java
Show resolved
Hide resolved
...roid/src/main/java/io/flutter/plugins/camera/features/noisereduction/NoiseReductionMode.java
Show resolved
Hide resolved
mvanbeusekom
suggested changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the newly added files are using the incorrect license header which causes the format
step in the tree to fail.
...d/src/main/java/io/flutter/plugins/camera/features/noisereduction/NoiseReductionFeature.java
Outdated
Show resolved
Hide resolved
...roid/src/main/java/io/flutter/plugins/camera/features/noisereduction/NoiseReductionMode.java
Outdated
Show resolved
Hide resolved
...c/test/java/io/flutter/plugins/camera/features/noisereduction/NoiseReductionFeatureTest.java
Outdated
Show resolved
Hide resolved
mvanbeusekom
approved these changes
Jun 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mvanbeusekom
added
the
waiting for tree to go green
(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
label
Jun 22, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 22, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 22, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 22, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Jul 10, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
p: camera
platform-android
waiting for tree to go green
(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the noise reduction feature containing the implementation to handle setting noise reduction levels via the Android Camera2 API.
This is the seventh PR in a series of pull-requests which will gradually introduce changes from PR #3651, making it easier to review the code (as discussed with @stuartmorgan).
Pre-launch Checklist
dart format
. See [plugin_tool format])[shared_preferences]
///
).