-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[camera] android-rework part 10: fixed final orientation issues. #4153
Conversation
Co-authored-by: Andrew Coutts <[email protected]>
Co-authored-by: Andrew Coutts <[email protected]>
…s_resolution_sensor_features
…s_resolution_sensor_features
…roid/supporting_functionality
…ra-android/supporting_functionality
…nsor_features' into camera-android/supporting_functionality
…droid/final-rework-implementation
…droid/final-rework-implementation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Can you elaborate on what these regressions are from? Earlier PRs in the series? If so, why are we landing the switch with known regressions and then fixing them, rather than fixing the in-progress PR? |
Setting the focus point would retrigger the autofocus sequence before the android refactor, but no longer in part 9.
As mentioned in part 9, after discussion with @mvanbeusekom, to keep the size of the PRs down so they're easier to review. Other than that, there is no consideration. Part 9 and 10 might as well be a single PR as far as I'm concerned. EDIT: If they're both considered small enough I can close this PR and just merge these changes into the part 9 PR. |
We should not deliberately land known regressions.
I'm not sure what the combined size is, but if it's too big with the regression fixed we should see if there's another way to cut it. |
Closing this in favour of being merged with #4059 instead. |
This PR fixes some regressions regarding setting the focus point, as well as some other related issues regarding orientation:
This is the final tenth PR in a series of pull-requests which will gradually introduce changes from PR #3651, making it easier to review the code (as discussed with @stuartmorgan).
As of right now, this PR will still be kept in draft mode, as it also contains changes it depends on from the previous parts. Once those have been merged and any changes from those have been merged back into this PR, the draft status will be removed.
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).