Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera]bump default camera_web package version #5873

Conversation

hellohuanlin
Copy link
Contributor

Follow up this PR that updates permission exceptions for camera_web package.

This should be landed together with the Android change since both are breaking changes.

List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#97199

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@hellohuanlin hellohuanlin force-pushed the camera_permission_update_example_and_readme branch from 6d0772b to 1a1de5a Compare May 31, 2022 19:07
@stuartmorgan
Copy link
Contributor

This should be landed together with the Android change since both are breaking changes.

Why is it a separate PR then? If landed, this would just be a breaking change.

To land them separately we would have to follow this process, which doesn't seem necessary given that this is a small change that could easily be combined with the other PR.

@hellohuanlin
Copy link
Contributor Author

@stuartmorgan Oh my bad. I intended for this to be rebased by @camsim99

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants