Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[Image_picker_android] example app ping video player version #5888

Closed

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Jun 2, 2022

Ping the video player version in the example app, video_player 2.3.5 might conflict image_picker.

Fixes: flutter/flutter#105182

No CHANGELOG change: example app only change.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require a minor version bump? Im not clear of the convention in plugins yet.

@cyanglaz cyanglaz marked this pull request as draft June 2, 2022 21:04
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Jun 2, 2022

@GaryQian No version bump required. this is only for example app.

I'm just testing the failure in this PR tho. The real fix might not be this as all the apps that depends on the latest image_picker and latest video_players would have the same build issue (if the issue is really due to video_playing updating the deps)

We will need to find a better fix for this.

@cyanglaz cyanglaz marked this pull request as ready for review June 2, 2022 21:18
@cyanglaz cyanglaz force-pushed the image_picker_ping_video_player branch from 7f32c91 to 80ea2b9 Compare June 2, 2022 21:52
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Jun 3, 2022

The image picker issue is fixed by #5889

@cyanglaz cyanglaz closed this Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flutter/plugin ci build failed on image_picker_android
2 participants