-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Handle Android camera permissions error code #5938
Conversation
@stuartmorgan Reading through the wiki, it seems like this PR should be reviewed first? Then the changes with |
@camsim99 This still needs a test, right? I can review it once it has one. |
@@ -56,37 +56,31 @@ void main() { | |||
}); | |||
|
|||
test( | |||
'Should throw CameraException when create throws a PlatformException', | |||
'Should throw StateError when create is called while camera permissions request ongoing', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a duplicate test (see test right below), so I just modified this one.
This PR isn't changing any interfaces, so there doesn't need to be any chaining for PRs AFAICT. I don't think we even need this PR though, since none of our implementations should be using the default method channel implementation now. Do we need to change the behavior of third-party camera implementations? If not, you can just skip this unless I'm missing something. |
Handles the new camera permissions code for Android that represents an ongoing request that was introduced in PR #5640.
Part of Issue #101384.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.