Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[file_selector] Add getDirectoryPaths method to the file_selector_platform_interface. #6572

Merged
merged 5 commits into from
Nov 18, 2022
Merged

[file_selector] Add getDirectoryPaths method to the file_selector_platform_interface. #6572

merged 5 commits into from
Nov 18, 2022

Conversation

eugerossetto
Copy link
Contributor

@eugerossetto eugerossetto commented Oct 13, 2022 •
edited
Loading

This PR adds the implementation of the method getDirectoryPaths to the file_selector_platform_interface.

Next, we will proceed this way:

  1. Add implementations for Windows, macOS and Linux in parallel. (The Windows implementation will be done when the Dart migration is ready)
  2. Add the new published version to the file_selector package with its example when at least one platform is published.
  3. Repeat 2 when the other new implementations are published.

Issue:
Support for selection of multiple directories, through desktop's native open panel, in 'file_selector' package #74323

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@adpinola adpinola mentioned this pull request Oct 14, 2022
Merged
11 tasks
@VanesaOshiro VanesaOshiro mentioned this pull request Oct 14, 2022
Closed
11 tasks
This was referenced Oct 14, 2022
Draft
Closed
@adpinola adpinola force-pushed the 74323-add-get-directories-paths-platform-interface branch from 9e6bf65 to 3982f4c Compare October 14, 2022 20:33
stuartmorgan
stuartmorgan suggested changes Oct 17, 2022
View reviewed changes
packages/file_selector/file_selector_platform_interface/CHANGELOG.md Outdated Show resolved Hide resolved
...or/file_selector_platform_interface/lib/src/method_channel/method_channel_file_selector.dart Outdated Show resolved Hide resolved
...or/file_selector_platform_interface/lib/src/method_channel/method_channel_file_selector.dart Outdated Show resolved Hide resolved
...tor/file_selector_platform_interface/lib/src/platform_interface/file_selector_interface.dart Outdated Show resolved Hide resolved
...tor/file_selector_platform_interface/lib/src/platform_interface/file_selector_interface.dart Outdated Show resolved Hide resolved
...tor/file_selector_platform_interface/lib/src/platform_interface/file_selector_interface.dart Show resolved Hide resolved
@adpinola
Copy link
Contributor

Hi Stuart, feedback applied. Thanks!

@eugerossetto eugerossetto changed the title [file_selector] Add getDirectoriesPaths method to the file_selector_platform_interface. [file_selector] Add getDirectoryPaths method to the file_selector_platform_interface. Oct 17, 2022
@adpinola adpinola force-pushed the 74323-add-get-directories-paths-platform-interface branch 2 times, most recently from b6e44cd to e3a66a2 Compare October 17, 2022 18:22
@adpinola
Copy link
Contributor

Hi @stuartmorgan, I think you can review it again. Thanks

@VanesaOshiro VanesaOshiro force-pushed the 74323-add-get-directories-paths-platform-interface branch 2 times, most recently from 407a9b8 to a67dad5 Compare October 18, 2022 19:59
stuartmorgan
stuartmorgan approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit. Thanks!

@cbracken for secondary review

...or/file_selector_platform_interface/lib/src/method_channel/method_channel_file_selector.dart Outdated Show resolved Hide resolved
@adpinola adpinola force-pushed the 74323-add-get-directories-paths-platform-interface branch 3 times, most recently from 67be46c to 19920f9 Compare October 19, 2022 20:41
@adpinola adpinola force-pushed the 74323-add-get-directories-paths-platform-interface branch from 19920f9 to cea5866 Compare November 2, 2022 12:35
@adpinola adpinola force-pushed the 74323-add-get-directories-paths-platform-interface branch 5 times, most recently from 2e95435 to dc4e24a Compare November 15, 2022 12:36
cbracken
cbracken approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo one comment (and one optional suggestion).

@adpinola adpinola force-pushed the 74323-add-get-directories-paths-platform-interface branch from dc4e24a to 834ffaa Compare November 17, 2022 19:21
@adpinola adpinola force-pushed the 74323-add-get-directories-paths-platform-interface branch from 834ffaa to 9c156fe Compare November 17, 2022 19:34
@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 17, 2022
@auto-submit auto-submit bot merged commit 2ba4c0a into flutter:main Nov 18, 2022
@adpinola adpinola deleted the 74323-add-get-directories-paths-platform-interface branch November 18, 2022 12:58
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
2ba4c0a70 [file_selector] Add getDirectoryPaths method to the file_se…
32feaae 
…lector_platform_interface. (flutter/plugins#6572)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
Roll Plugins from a2fa4e95221f to b2fe01bc0f29 (6 revisions) (#115656)
7fd3bb2 
* 19673b341 [camera]: Bump camerax_version (flutter/plugins#6709)

* b8282424e [gh_actions]: Bump ossf/scorecard-action from 2.0.4 to 2.0.6 (flutter/plugins#6610)

* 2ba4c0a70 [file_selector] Add getDirectoryPaths method to the file_selector_platform_interface. (flutter/plugins#6572)

* 89cbf74c8 [quick_actions]Migrates all remaining components to Swift, and deprecate OCMock (flutter/plugins#6597)

* 51d084453 [quick_actions] Fix Android integration test flake (flutter/plugins#6688)

* b2fe01bc0 [google_sign_in] Correctly passes `serverClientId` to native libs (flutter/plugins#6691)
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022
@eugerossetto @adpinola
[file_selector] Add getDirectoryPaths method to the file_selector_pla…
a04f6dc 
…tform_interface. (flutter#6572)

* Add getDirectoriesPaths method to the file_selector_platform_interface

* Add getDirectoriesPaths to method channel.

* Increment version to 2.3.0

* apply feedback

* extract assertion method

Co-authored-by: Alejandro Pinola <[email protected]>
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
Roll Plugins from a2fa4e95221f to b2fe01bc0f29 (6 revisions) (flutter…
145a3d5 
…#115656)

* 19673b341 [camera]: Bump camerax_version (flutter/plugins#6709)

* b8282424e [gh_actions]: Bump ossf/scorecard-action from 2.0.4 to 2.0.6 (flutter/plugins#6610)

* 2ba4c0a70 [file_selector] Add getDirectoryPaths method to the file_selector_platform_interface. (flutter/plugins#6572)

* 89cbf74c8 [quick_actions]Migrates all remaining components to Swift, and deprecate OCMock (flutter/plugins#6597)

* 51d084453 [quick_actions] Fix Android integration test flake (flutter/plugins#6688)

* b2fe01bc0 [google_sign_in] Correctly passes `serverClientId` to native libs (flutter/plugins#6691)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Plugins from a2fa4e95221f to b2fe01bc0f29 (6 revisions) (flutter…
4d56177 
…#115656)

* 19673b341 [camera]: Bump camerax_version (flutter/plugins#6709)

* b8282424e [gh_actions]: Bump ossf/scorecard-action from 2.0.4 to 2.0.6 (flutter/plugins#6610)

* 2ba4c0a70 [file_selector] Add getDirectoryPaths method to the file_selector_platform_interface. (flutter/plugins#6572)

* 89cbf74c8 [quick_actions]Migrates all remaining components to Swift, and deprecate OCMock (flutter/plugins#6597)

* 51d084453 [quick_actions] Fix Android integration test flake (flutter/plugins#6688)

* b2fe01bc0 [google_sign_in] Correctly passes `serverClientId` to native libs (flutter/plugins#6691)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@eugerossetto @adpinola @mauricioluz
[file_selector] Add getDirectoryPaths method to the file_selector_pla…
f583e11 
…tform_interface. (flutter#6572)

* Add getDirectoriesPaths method to the file_selector_platform_interface

* Add getDirectoriesPaths to method channel.

* Increment version to 2.3.0

* apply feedback

* extract assertion method

Co-authored-by: Alejandro Pinola <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adpinola adpinola adpinola left review comments

@cbracken cbracken cbracken approved these changes

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: file_selector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eugerossetto @adpinola @stuartmorgan @cbracken