Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[ci] Import flutter/packages install_chromium.sh #6727

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

stuartmorgan
Copy link
Contributor

Brings over the newer flutter/packages version of install_chromium.sh as part of pre-aligning the repositories for later merging.

Thing imports the script and the .cirrus.yaml template without any changes.

Part of flutter/flutter#113764

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Brings over the newer flutter/packages version of install_chromium.sh as
part of pre-aligning the repositories for later merging.

Part of flutter/flutter#113764
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for bringing this over! Apologies for my unfixed bugs! 😅

.cirrus.yml Outdated Show resolved Hide resolved
script/install_chromium.sh Show resolved Hide resolved
Co-authored-by: David Iglesias <[email protected]>
@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 22, 2022
@auto-submit auto-submit bot merged commit 2a52394 into flutter:main Nov 22, 2022
josh88versa pushed a commit to versa-asia/plugins that referenced this pull request Nov 23, 2022
* [ci] Import flutter/packages install_chromium.sh

Brings over the newer flutter/packages version of install_chromium.sh as
part of pre-aligning the repositories for later merging.

Part of flutter/flutter#113764

* Update .cirrus.yml

Co-authored-by: David Iglesias <[email protected]>

Co-authored-by: David Iglesias <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 23, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 23, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 23, 2022
* 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727)

* e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729)

* fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742)

* dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744)

* b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746)

* be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693)

* a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…#115930)

* 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727)

* e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729)

* fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742)

* dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744)

* b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746)

* be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693)

* a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…#115930)

* 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727)

* e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729)

* fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742)

* dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744)

* b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746)

* be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693)

* a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
* [ci] Import flutter/packages install_chromium.sh

Brings over the newer flutter/packages version of install_chromium.sh as
part of pre-aligning the repositories for later merging.

Part of flutter/flutter#113764

* Update .cirrus.yml

Co-authored-by: David Iglesias <[email protected]>

Co-authored-by: David Iglesias <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants