Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable Cocoon test to unblock flutter/flutter#138521 #346

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Temporarily disable Cocoon test to unblock flutter/flutter#138521 #346

merged 1 commit into from
Feb 16, 2024

Conversation

QuncCccccc
Copy link
Contributor

The code change in flutter/flutter#138521 causes some golden diffs. The diffs are small and will be fixed once #138521 is landed.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@QuncCccccc QuncCccccc marked this pull request as ready for review February 16, 2024 19:19
keyonghan
keyonghan approved these changes Feb 16, 2024
View reviewed changes
Copy link

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot merged commit ade5b1b into main Feb 16, 2024
12 checks passed
@auto-submit auto-submit bot deleted the temp_disable_cocoon_test branch February 16, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan approved these changes

Assignees
No one assigned
Labels
autosubmit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuncCccccc @keyonghan