Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zulip to use Color{,Swatch} asserts that tolerate float errors #409

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

chrisbobbe
Copy link
Contributor

Fixes flutter/flutter#155113.

This pulls in:
zulip/zulip-flutter@cdbe14122
zulip/zulip-flutter#949

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Member

@gnprice gnprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM assuming tests pass.

@gaaclarke FYI

@gaaclarke
Copy link
Member

A lot of people are off at a conference, but I'll try to get it relanded tomorrow. Thanks.

@gnprice
Copy link
Member

gnprice commented Sep 19, 2024

Cool, sounds good.

If you hit "approve" on this PR, then we can land this flutter/tests update to prepare for that.

(I guess the GitHub UI is offering to let me merge it already. But I think the intended policy is that PRs here require two flutter-hackers approvals to merge, just like in the main Flutter repos, and we just haven't set things up to enforce that here.)

@auto-submit auto-submit bot merged commit 3fb1adc into flutter:main Sep 19, 2024
12 checks passed
@gnprice
Copy link
Member

gnprice commented Sep 19, 2024

Let's see if the autosubmit bot is active here… yep!

@chrisbobbe chrisbobbe deleted the pr-color-asserts-float-errors branch September 19, 2024 00:30
@gnprice gnprice mentioned this pull request Sep 20, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zulip test needs to migrate color assertions
3 participants