-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flutter_cocoon test #413
Conversation
it looks like |
1751aba
to
822febc
Compare
Rebasing to see if it resolves the failures here so we can unblock the other PR |
auto label is removed for flutter/tests/413, due to - The status or check suite linux_tests (shard 3 of 3, 2) has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Hmm I do not know why this is failing. Will look in flutter/cocoon. |
flutter/cocoon#3953 should unblock this, but we'll need to update the hash for flutter/cocoon here. |
This fixes a failure in flutter/tests when running `dart fix apply` + `dart format . --line-length=120` Found in flutter/tests#413
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the commit ref to include Kate's other fixes.
Thanks!
Thanks @parlough!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unblocks flutter/flutter#155072
This updates flutter_cocoon test so the flutter/flutter#155072 can test the latest flutter_cocoon after flutter/cocoon#3901 fix.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.