Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flutter_cocoon test #413

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

TahaTesser
Copy link
Member

Unblocks flutter/flutter#155072

This updates flutter_cocoon test so the flutter/flutter#155072 can test the latest flutter_cocoon after flutter/cocoon#3901 fix.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

parlough
parlough previously approved these changes Oct 3, 2024
@TahaTesser
Copy link
Member Author

it looks like flutter_cocoon has bunch of other failures. Do we fix them all to update customer_test commit?

@Piinks
Copy link
Contributor

Piinks commented Oct 15, 2024

Rebasing to see if it resolves the failures here so we can unblock the other PR

@auto-submit auto-submit bot removed the autosubmit label Oct 15, 2024
Copy link

auto-submit bot commented Oct 15, 2024

auto label is removed for flutter/tests/413, due to - The status or check suite linux_tests (shard 3 of 3, 2) has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite linux_tests (shard 2 of 3, 1) has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks
Copy link
Contributor

Piinks commented Oct 15, 2024

Hmm I do not know why this is failing. Will look in flutter/cocoon.

@Piinks
Copy link
Contributor

Piinks commented Oct 15, 2024

flutter/cocoon#3953 should unblock this, but we'll need to update the hash for flutter/cocoon here.

auto-submit bot pushed a commit to flutter/cocoon that referenced this pull request Oct 15, 2024
This fixes a failure in flutter/tests when running `dart fix apply` + `dart format . --line-length=120`
Found in flutter/tests#413
parlough
parlough previously approved these changes Oct 16, 2024
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the commit ref to include Kate's other fixes.

Thanks!

@Piinks
Copy link
Contributor

Piinks commented Oct 16, 2024

Thanks @parlough!!

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks merged commit 63b8d65 into flutter:main Oct 16, 2024
12 checks passed
@TahaTesser TahaTesser deleted the update_flutter_cocoon_test branch October 21, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants