Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding adaptation info for text fields #8913

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Adding adaptation info for text fields #8913

merged 3 commits into from
Jun 22, 2023

Conversation

leighajarett
Copy link
Contributor

Fixes: #8678

Presubmit checklist

atsansone
atsansone approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leighajarett : I have two nits, otherwise this is LGTM. If you choose to make these changes, you can do so and merge without sending it back to me.

src/resources/platform-adaptations.md Outdated Show resolved Hide resolved
src/resources/platform-adaptations.md Outdated Show resolved Hide resolved
@atsansone atsansone added the st.RFM.% Ready to merge or land with minor changes. No further review needed. label Jun 20, 2023
@leighajarett
Copy link
Contributor Author

@atsansone Thanks! Added the autosubmit label

sfshaza2
sfshaza2 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit 87274fb into flutter:main Jun 22, 2023
@sfshaza2 sfshaza2 removed the st.RFM.% Ready to merge or land with minor changes. No further review needed. label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@atsansone atsansone atsansone approved these changes

@parlough parlough Awaiting requested review from parlough parlough is a code owner

Assignees

@leighajarett leighajarett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add adaptation information for text fields
3 participants
@leighajarett @atsansone @sfshaza2