-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👷 Handle symbolic links between host platforms and containers #9320
Conversation
Visit the preview URL for this PR (updated for commit 0ff7348): https://flutter-docs-prod--pr9320-feat-handle-symlinks-mjp8vrtv.web.app (expires Wed, 08 Nov 2023 03:52:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d5ba327eec813901cac8396c4f458b02288624ab |
Requires #9307. |
eac4f6e
to
19c3f12
Compare
PTAL @parlough |
@parlough It's not working. :( |
3ed02c4
to
5eedf4a
Compare
I think that's just because the test.sh script wasn't updated to handle the changes. That's why the other PR simplifies the testing. |
It's ready on my side. Passing to @parlough. :) |
@parlough : Can you make the needed changes please? |
Yep. I discussed with Alex and I'll get back to this soon if something else I'm trying doesn't work out. |
@parlough : Any updates? |
Thanks for working on this Alex and for being patient!! Sorry about the recurring delay on reviewing it and getting it landed. We plan to remove the Docker setup from the repository, at least for now, sometime within the next few weeks. I'll have more updates soon. I'll also be making sure to spend time getting things working on Windows too. So since this is going to be dropped since, I'll close this for now. Thanks again 💙 |
Great move, congrats! |
Description of what this PR is changing or adding, and why:
Replaces all symlinks to the actual destination by copying corresponding files and directories.
Issues fixed by this PR (if any):
make setup
fails with/usr/bin/env: ‘bash\r’: No such file or directory
#6201Presubmit checklist