Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Handle symbolic links between host platforms and containers #9320

Closed
wants to merge 18 commits into from

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Aug 28, 2023

Description of what this PR is changing or adding, and why:
Replaces all symlinks to the actual destination by copying corresponding files and directories.

Issues fixed by this PR (if any):

Presubmit checklist

@github-actions
Copy link

github-actions bot commented Aug 28, 2023

Visit the preview URL for this PR (updated for commit 0ff7348):

https://flutter-docs-prod--pr9320-feat-handle-symlinks-mjp8vrtv.web.app

(expires Wed, 08 Nov 2023 03:52:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d5ba327eec813901cac8396c4f458b02288624ab

@AlexV525
Copy link
Member Author

Requires #9307.

@AlexV525
Copy link
Member Author

On Windows 🎆

image

@atsansone atsansone added infra.structure Relates to the tools that create docs.flutter.dev st.WIP Issue in progress labels Aug 28, 2023
@AlexV525 AlexV525 marked this pull request as ready for review September 17, 2023 02:52
@AlexV525 AlexV525 force-pushed the feat/handle-symlinks branch 2 times, most recently from eac4f6e to 19c3f12 Compare September 17, 2023 06:25
@domesticmouse
Copy link
Contributor

PTAL @parlough

@AlexV525
Copy link
Member Author

@parlough It's not working. :(

@parlough
Copy link
Member

parlough commented Sep 19, 2023

I think that's just because the test.sh script wasn't updated to handle the changes. That's why the other PR simplifies the testing.

@atsansone
Copy link
Contributor

@AlexV525 , @parlough : Is this still an active concern or fix? If so, I'd love to approve and merge soon.

@AlexV525
Copy link
Member Author

I think that's just because the test.sh script wasn't updated to handle the changes. That's why the other PR simplifies the testing.

It's ready on my side. Passing to @parlough. :)

@atsansone
Copy link
Contributor

@parlough : Can you make the needed changes please?

@atsansone atsansone added review.await-update Awaiting Updates after Edits and removed st.WIP Issue in progress labels Oct 17, 2023
@parlough
Copy link
Member

Yep. I discussed with Alex and I'll get back to this soon if something else I'm trying doesn't work out.

@atsansone
Copy link
Contributor

@parlough : Any updates?

@parlough
Copy link
Member

Thanks for working on this Alex and for being patient!! Sorry about the recurring delay on reviewing it and getting it landed.

We plan to remove the Docker setup from the repository, at least for now, sometime within the next few weeks. I'll have more updates soon. I'll also be making sure to spend time getting things working on Windows too.

So since this is going to be dropped since, I'll close this for now. Thanks again 💙

@parlough parlough closed this Jan 24, 2024
@AlexV525
Copy link
Member Author

We plan to remove the Docker setup from the repository, at least for now, sometime within the next few weeks

Great move, congrats!

@parlough parlough deleted the feat/handle-symlinks branch January 24, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra.structure Relates to the tools that create docs.flutter.dev review.await-update Awaiting Updates after Edits
Projects
None yet
4 participants