Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose some decoration properties for PaletteHuePicker #22

Merged
merged 25 commits into from
Aug 26, 2023
Merged

Expose some decoration properties for PaletteHuePicker #22

merged 25 commits into from
Aug 26, 2023

Conversation

Arenukvern
Copy link
Contributor

Hello,

This is small PR which should help to customise borders and border radius for PaletteHuePicker.

Will glad for your review!

AlexV525
AlexV525 reviewed Jun 20, 2022
View reviewed changes
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Left some suggestions.

lib/src/pickers/palette_hue_picker.dart Outdated Show resolved Hide resolved
lib/src/widgets/palette_picker.dart Outdated Show resolved Hide resolved
lib/src/widgets/palette_picker.dart Outdated Show resolved Hide resolved
lib/src/widgets/palette_picker.dart Outdated Show resolved Hide resolved
lib/src/widgets/slider_picker.dart Outdated Show resolved Hide resolved
lib/src/widgets/slider_picker.dart Outdated Show resolved Hide resolved
@nohli
Copy link
Collaborator

nohli commented Dec 7, 2022

@Arenukvern could you please address the code review comments?
Do you have any questions?

@Arenukvern
Copy link
Contributor Author

Arenukvern commented Dec 7, 2022 •
edited
Loading

@Arenukvern could you please address the code review comments?
Do you have any questions?

@nohli
Hi, sorry, forgot about this PR:)
no, I don't have any questions, will make changes accordingly tomorrow and submit them again.

@Arenukvern
Copy link
Contributor Author

@nohli Fixed all comments, sent review request

nohli
nohli reviewed Dec 8, 2022
View reviewed changes
lib/src/pickers/palette_hue_picker.dart Outdated Show resolved Hide resolved
lib/src/pickers/palette_hue_picker.dart Outdated Show resolved Hide resolved
lib/src/pickers/palette_hue_picker.dart Outdated Show resolved Hide resolved
lib/src/pickers/palette_hue_picker.dart Outdated Show resolved Hide resolved
lib/src/pickers/palette_hue_picker.dart Outdated Show resolved Hide resolved
lib/src/pickers/palette_hue_picker.dart Outdated Show resolved Hide resolved
lib/src/pickers/palette_hue_picker.dart Outdated Show resolved Hide resolved
nohli
nohli reviewed Dec 8, 2022
View reviewed changes
lib/src/widgets/palette_picker.dart Outdated Show resolved Hide resolved
lib/src/widgets/palette_picker.dart Outdated Show resolved Hide resolved
lib/src/widgets/slider_picker.dart Outdated Show resolved Hide resolved
@nohli
Copy link
Collaborator

nohli commented Dec 8, 2022

@Arenukvern cool thanks!
Looks good, just had a few nit questions.

Arenukvern and others added 9 commits December 8, 2022 11:54
@Arenukvern @nohli
Update lib/src/pickers/palette_hue_picker.dart
96b7c01 
Co-authored-by: Joachim Nohl <[email protected]>
@Arenukvern @nohli
Update lib/src/pickers/palette_hue_picker.dart
f156759 
Co-authored-by: Joachim Nohl <[email protected]>
@Arenukvern @nohli
Update lib/src/pickers/palette_hue_picker.dart
c583680 
Co-authored-by: Joachim Nohl <[email protected]>
@Arenukvern @nohli
Update lib/src/pickers/palette_hue_picker.dart
d5c60d0 
Co-authored-by: Joachim Nohl <[email protected]>
@Arenukvern @nohli
Update lib/src/pickers/palette_hue_picker.dart
4cd98c3 
Co-authored-by: Joachim Nohl <[email protected]>
@Arenukvern @nohli
Update lib/src/pickers/palette_hue_picker.dart
997c8d0 
Co-authored-by: Joachim Nohl <[email protected]>
@Arenukvern @nohli
Update lib/src/pickers/palette_hue_picker.dart
2d21259 
Co-authored-by: Joachim Nohl <[email protected]>
@Arenukvern
perf: fixes
12195f7
@Arenukvern
Merge remote-tracking branch 'origin/master'
84204f1
@Arenukvern
Copy link
Contributor Author

@nohli answered & fixed, please see new changes

nohli
nohli reviewed Dec 9, 2022
View reviewed changes
lib/src/widgets/slider_picker.dart Outdated Show resolved Hide resolved
lib/src/widgets/slider_picker.dart Outdated Show resolved Hide resolved
lib/src/widgets/slider_picker.dart Outdated Show resolved Hide resolved
lib/src/widgets/slider_picker.dart Outdated Show resolved Hide resolved
lib/src/pickers/palette_hue_picker.dart Outdated Show resolved Hide resolved
nohli
nohli approved these changes Dec 23, 2022
View reviewed changes
Copy link
Collaborator

@nohli nohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your contribution.
Just double-checking with @AlexV525 🙂

@nohli nohli requested review from AlexV525 and removed request for AlexV525 December 23, 2022 08:42
AlexV525
AlexV525 reviewed Dec 23, 2022
View reviewed changes
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nit picking.

lib/src/widgets/slider_picker.dart Outdated Show resolved Hide resolved
lib/src/widgets/palette_picker.dart Outdated Show resolved Hide resolved
lib/src/widgets/slider_picker.dart Outdated Show resolved Hide resolved
@nohli nohli self-assigned this Jun 1, 2023
@nohli nohli requested a review from AlexV525 August 26, 2023 02:52
@AlexV525
Copy link
Member

Ah, this is taking too long to land, sorry about that.

@nohli nohli merged commit 575d3b6 into fluttercandies:master Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 AlexV525 approved these changes

@nohli nohli nohli approved these changes

Assignees

@nohli nohli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arenukvern @nohli @AlexV525