-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose some decoration properties for PaletteHuePicker #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Left some suggestions.
@Arenukvern could you please address the code review comments? |
@nohli |
@nohli Fixed all comments, sent review request |
@Arenukvern cool thanks! |
Co-authored-by: Joachim Nohl <[email protected]>
Co-authored-by: Joachim Nohl <[email protected]>
Co-authored-by: Joachim Nohl <[email protected]>
Co-authored-by: Joachim Nohl <[email protected]>
Co-authored-by: Joachim Nohl <[email protected]>
Co-authored-by: Joachim Nohl <[email protected]>
Co-authored-by: Joachim Nohl <[email protected]>
@nohli answered & fixed, please see new changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for your contribution.
Just double-checking with @AlexV525 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nit picking.
Ah, this is taking too long to land, sorry about that. |
Hello,
This is small PR which should help to customise borders and border radius for PaletteHuePicker.
Will glad for your review!