[iOS] Handle error when fetching thumbnail #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
|
This is the video that I can't fetch thumbnail from. Add it to your library and call |
AlexV525
reviewed
Jun 21, 2024
maksg
force-pushed
the
ios-handle-thumbnail-error
branch
2 times, most recently
from
d2e728d
to
ca666b7
Compare
maksg
force-pushed
the
ios-handle-thumbnail-error
branch
from
ca666b7
to
8116585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my videos can't generate a thumbnail and it causes the error
Domain=PHPhotosErrorDomain Code=3303, resulting infetchThumbnever calling back.We should handle this case probably the same way as when
imageDataisnil.I'm attaching the video I have issue with.
Desktop.2024.02.17.-.15.21.48.01.MP4