Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ratakondala-arun/windows-support #382

Merged
merged 5 commits into from
Jul 26, 2022
Merged

Ratakondala-arun/windows-support #382

merged 5 commits into from
Jul 26, 2022

Conversation

RatakondalaArun
Copy link
Contributor

  • added support for windows (c22a950)
  • added tests for windows (77b8ada)

closes #380

@RatakondalaArun RatakondalaArun self-assigned this Jul 24, 2022
@MarkOSullivan94 MarkOSullivan94 force-pushed the RatakondalaArun/add-windows-support branch from c3c0c4f to bc9b5fb Compare July 26, 2022 09:13
MarkOSullivan94
MarkOSullivan94 requested changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@MarkOSullivan94 MarkOSullivan94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments other than that all great!

lib/constants.dart Outdated Show resolved Hide resolved
lib/windows/windows_icon_generator.dart Outdated Show resolved Hide resolved
@MarkOSullivan94 MarkOSullivan94 marked this pull request as draft July 26, 2022 09:18
@RatakondalaArun RatakondalaArun marked this pull request as ready for review July 26, 2022 09:31
@RatakondalaArun
Copy link
Contributor Author

@MarkOSullivan94 made all the changes you requested for

@RatakondalaArun
Copy link
Contributor Author

RatakondalaArun commented Jul 26, 2022 •
edited
Loading

Let's stick to not using relative imports
#382 (comment)

we can use the always_use_package_imports linter rule to warn collaborators against using relative imports

I recommend we add this rule in separate PR since this will be out of the scope of this PR

MarkOSullivan94
MarkOSullivan94 approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@MarkOSullivan94 MarkOSullivan94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MarkOSullivan94 MarkOSullivan94 merged commit 3f30632 into master Jul 26, 2022
@RatakondalaArun RatakondalaArun deleted the RatakondalaArun/add-windows-support branch August 2, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkOSullivan94 MarkOSullivan94 MarkOSullivan94 approved these changes

Assignees

@RatakondalaArun RatakondalaArun

Labels
improvement platform:windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

windows-support
2 participants
@RatakondalaArun @MarkOSullivan94