Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Upgraded image:^3.0.2 to image:^4.0.15 #447

Merged
merged 7 commits into from
Feb 24, 2023
Merged

- Upgraded image:^3.0.2 to image:^4.0.15 #447

merged 7 commits into from
Feb 24, 2023

Conversation

carloshpb
Copy link
Contributor

@carloshpb carloshpb commented Jan 16, 2023 •
edited
Loading

  • Upgraded image:^3.0.2 to image:^4.0.11 and fixed breaking changes done by the upgrade.
  • I couldn't run the all_tests on my notebook as my Android Emulator is not working right now (and I also don't have an iOS). If possible, run the test and refuse it if it doesn't work.

@dancamdev dancamdev mentioned this pull request Jan 18, 2023
Closed
kalyujniy
kalyujniy reviewed Jan 23, 2023
View reviewed changes
pubspec.yaml Outdated Show resolved Hide resolved
@carloshpb carloshpb changed the title - Upgraded image:^3.0.2 to image:^4.0.10 - Upgraded image:^3.0.2 to image:^4.0.11 Jan 23, 2023
@carloshpb carloshpb changed the title - Upgraded image:^3.0.2 to image:^4.0.11 - Upgraded image:^3.0.2 to image:^4.0.13 Feb 2, 2023
mrquantumoff
mrquantumoff approved these changes Feb 10, 2023
View reviewed changes
Copy link

@mrquantumoff mrquantumoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. I hope this will be merged soon

@eugenio-d-tesio
Copy link

Looks good for me too.

@carloshpb carloshpb changed the title - Upgraded image:^3.0.2 to image:^4.0.13 - Upgraded image:^3.0.2 to image:^4.0.15 Feb 13, 2023
@lsaudon
Copy link

lsaudon commented Feb 13, 2023

Looks good for me too.

@lsaudon
Copy link

lsaudon commented Feb 21, 2023

Why is this pull request not merged?

@mrquantumoff
Copy link

It seems like the library is seeking for new maintainers #363

@tim-eucalyptus
Copy link

please merge and publish new package.

dab246
dab246 approved these changes Feb 23, 2023
View reviewed changes
Copy link

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge it soon

@MarkOSullivan94 MarkOSullivan94 merged commit 2a9185a into fluttercommunity:master Feb 24, 2023
@MarkOSullivan94
Copy link
Collaborator

@carloshpb thank you for this! ❤️

Apologies for the delay in getting it merged

This was referenced Feb 24, 2023
Closed
Closed
@ycherniavskyi ycherniavskyi mentioned this pull request Feb 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalyujniy kalyujniy kalyujniy left review comments

@cfchris cfchris cfchris left review comments

@dab246 dab246 dab246 approved these changes

@mrquantumoff mrquantumoff mrquantumoff approved these changes

@TheHypnoo TheHypnoo TheHypnoo approved these changes

@lsaudon lsaudon lsaudon approved these changes

@MarkOSullivan94 MarkOSullivan94 MarkOSullivan94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@carloshpb @eugenio-d-tesio @lsaudon @mrquantumoff @tim-eucalyptus @MarkOSullivan94 @cfchris @kalyujniy @TheHypnoo @dab246