Update README.md #541
Closed
Update README.md #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed "flutter_launcher_icons" to "flutter_icons" to fix broken example. The dependency should be "flutter_launcher_icons" (as is) but the paths need to be specified under "flutter_icons" (currently the example says "flutter_launcher_icons" which results in this error: ✗ ERROR: NoConfigFoundException No configuration found in flutter_launcher_icons.yaml or in pubspec.yaml. In case file exists in different directory use --file option #0 createIconsFromArguments (package:flutter_launcher_icons/main.dart:85:7) but changing it to "flutter_icons" works: Creating Icons for Web... Creating Icons for Windows... Creating Icons for MacOS... ✓ Successfully generated launcher icons
vanlooverenkoen
approved these changes
Mar 14, 2024
vanlooverenkoen
suggested changes
Mar 14, 2024
There was a problem hiding this comment.
flutter_launcher_icons should be the new implementatioon. So not sure why you are removing this for the old implementation? #478
|
Version v0.13.1 and onwards will allow you to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed "flutter_launcher_icons" to "flutter_icons" to fix broken example. The dependency should be "flutter_launcher_icons" (as is) but the paths need to be specified under "flutter_icons" (currently the example says "flutter_launcher_icons" which results in this error:
✗ ERROR: NoConfigFoundException
No configuration found in flutter_launcher_icons.yaml or in pubspec.yaml. In case file exists in different directory use --file option
#0 createIconsFromArguments (package:flutter_launcher_icons/main.dart:85:7)
but changing it to "flutter_icons" works:
Creating Icons for Web...
Creating Icons for Windows...
Creating Icons for MacOS...
✓ Successfully generated launcher icons
-> I actually had to google as the example wasn't working, but StackOverflow to the rescue:
https://stackoverflow.com/questions/69509861/check-that-your-config-file-flutter-launcher-icons-yaml-has-a-flutter-icons