Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS web view plugin #3

Merged
merged 1 commit into from
Jun 20, 2017
Merged

Conversation

toufikzitouni
Copy link

I’m using GeneratedPluginRegistrant because that’s the supported plugin
in the new Flutter version. I couldn’t compile the code without it
unfortunately

@lejard-h lejard-h self-requested a review June 19, 2017 07:51
@lejard-h
Copy link
Collaborator

Thanks, I will test it, anything to configure or it just work ?

Copy link
Collaborator

@lejard-h lejard-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add your name as an author in pubspec.yaml, and update the README with an IOS part that explain how to integrate the plugin ?

@@ -1,3 +1,22 @@
PODFILE CHECKSUM: fe68fbd35e5bc75c5acdec41319edc0cdaebd038
PODS:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this file should be in gitignore

@toufikzitouni
Copy link
Author

No special setup needed. But I do think the plugin should be updated to work with the new version of the Flutter sdk that uses GeneratedPluginRegistrant. Were you able to test it successfully?

@lejard-h
Copy link
Collaborator

Yes tested successfuly, I had to update my project.

But the clearCookies params does not work, the app just shutdown for me, without error.

you can test it,
https://github.com/dart-flitter/flitter/blob/webview_ios/lib/services/flutter_gitter_auth.dart#L61

@lejard-h
Copy link
Collaborator

Last thing, is it possible to have a parameter to have a completely fullscreen view, without the top bar with the "Done" button ? If you prefer we can do it later, in an other pull request it is not blocking

- Fixed crash with clearCookies
- Added flag to toggle full screen mode
- Updated README
- Updated pubspec.yaml authors section
@toufikzitouni
Copy link
Author

I've added the changes you requested, including adding a fullScreen param to toggle full screen mode for the WebView

@lejard-h lejard-h merged commit dca43de into fluttercommunity:master Jun 20, 2017
@lejard-h lejard-h mentioned this pull request Jun 20, 2017
@lejard-h
Copy link
Collaborator

lejard-h commented Jun 20, 2017

Nice I still have the top bar with the Done button but I will merge this pull request, I will create issues.

Thank you very much ;)

#5
#4

lejard-h pushed a commit that referenced this pull request Dec 20, 2017
ios and android more implement
@MaskyS MaskyS mentioned this pull request Apr 10, 2018
lejard-h pushed a commit that referenced this pull request May 24, 2018
@l1Dan l1Dan mentioned this pull request Nov 8, 2018
charafau pushed a commit that referenced this pull request Apr 7, 2020
ios and android more implement
charafau pushed a commit that referenced this pull request Apr 7, 2020
@ektelat ektelat mentioned this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants