bug: we should not assume that the cluster domain is cluster.local #139
Assignees
Comments
dmccaffery
added a commit
to dmccaffery/fluxcd-community-helm-charts
that referenced
this issue
Nov 4, 2022
…y#139) * add new `clusterDomain` variable which defaults to `cluster.local` * use `clusterDomain` for source-controller `storage-adv-addr` argument * use `clusterDomain` for `events-addr` argument NOTES: The source-controller manifest included a hard-coded advertising address with `cluster.local`. In some environments, the cluster domain is modified, which broke the kustomize controller from being able to resolve the source controller to acquire artifacts. BREAKING CHANGE: The `eventsaddr` variable has been removed as it is no longer necessary. The new `clusterDomain` variable is now used to create a fully-qualified addresses throughout the deployment manifiests. Signed-off-by: Deavon M. McCaffery <[email protected]>
dmccaffery
added a commit
to dmccaffery/fluxcd-community-helm-charts
that referenced
this issue
Nov 4, 2022
…y#139) * add new `clusterDomain` variable which defaults to `cluster.local` * use `clusterDomain` for source-controller `storage-adv-addr` argument * use `clusterDomain` for `events-addr` argument NOTES: The source-controller manifest included a hard-coded advertising address with `cluster.local`. In some environments, the cluster domain is modified, which broke the kustomize controller from being able to resolve the source controller to acquire artifacts. BREAKING CHANGE: The `eventsaddr` variable has been removed as it is no longer necessary. The new `clusterDomain` variable is now used to create a fully-qualified addresses throughout the deployment manifiests. Signed-off-by: Deavon M. McCaffery <[email protected]>
dmccaffery
added a commit
to dmccaffery/fluxcd-community-helm-charts
that referenced
this issue
Nov 4, 2022
…y#139) * add new `clusterDomain` variable which defaults to `cluster.local` * use `clusterDomain` for source-controller `storage-adv-addr` argument * use `clusterDomain` for `events-addr` argument NOTES: The source-controller manifest included a hard-coded advertising address with `cluster.local`. In some environments, the cluster domain is modified, which broke the kustomize controller from being able to resolve the source controller to acquire artifacts. BREAKING CHANGE: The `eventsaddr` variable has been removed as it is no longer necessary. The new `clusterDomain` variable is now used to create a fully-qualified addresses throughout the deployment manifiests. Signed-off-by: Deavon M. McCaffery <[email protected]>
This was referenced Nov 4, 2022
dmccaffery
added a commit
that referenced
this issue
Nov 5, 2022
* add new `clusterDomain` variable which defaults to `cluster.local` * use `clusterDomain` for source-controller `storage-adv-addr` argument * use `clusterDomain` for `events-addr` argument NOTES: The source-controller manifest included a hard-coded advertising address with `cluster.local`. In some environments, the cluster domain is modified, which broke the kustomize controller from being able to resolve the source controller to acquire artifacts. BREAKING CHANGE: The `eventsaddr` variable has been removed as it is no longer necessary. The new `clusterDomain` variable is now used to create a fully-qualified addresses throughout the deployment manifiests. Signed-off-by: Deavon M. McCaffery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
helm-charts/charts/flux2/templates/source-controller.yaml
Line 47 in b3761ba
In our environments, we do not use the default cluster domain of cluster.local -- this either needs to be a variable, or allow resolv search domains to be used by dropping the domain.
The text was updated successfully, but these errors were encountered: