Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for istio's warmupDurationSecs #1350

Closed
recarga-brubs opened this issue Jan 24, 2023 · 3 comments · Fixed by #1540
Closed

Support for istio's warmupDurationSecs #1350

recarga-brubs opened this issue Jan 24, 2023 · 3 comments · Fixed by #1540

Comments

@recarga-brubs
Copy link

Describe the feature

Istio added in 2022 the ability to "warm up" traffic slowly with a new load balancer property called warmupDurationSecs https://istio.io/latest/docs/reference/config/networking/destination-rule/#LoadBalancerSettings

Flagger should also support LEAST_REQUEST loadbalancer configuration https://istio.io/latest/docs/reference/config/networking/destination-rule/#LoadBalancerSettings-SimpleLB

Proposed solution

Add support for new istio loadbalancer features so a configuration like this would be possible

...
    trafficPolicy:
      loadBalancer:
        simple: LEAST_REQUEST
        warmupDurationSecs: 30s
...

Any alternatives you've considered?

No

@aryan9600
Copy link
Member

@recarga-brubs thanks for opening this issue. would you like to take it on?

@flaviomrjr
Copy link

@aryan9600 is there any chance to add this feature?
It would be really helpful to enable this feature as shown in this thread:
https://stackoverflow.com/questions/74517652/gradually-warm-java-application-in-k8s-with-istio

@S-mishina
Copy link
Contributor

@aryan9600
Nice to meet you.
I addressed this issue here.
If I am wrong, please point it out to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants