Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Istio Destination Rule WarmupDurationSecs #1540

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Support Istio Destination Rule WarmupDurationSecs #1540

merged 1 commit into from
Oct 17, 2023

Conversation

S-mishina
Copy link
Contributor

@S-mishina S-mishina commented Oct 15, 2023 •
edited by aryan9600
Loading

Fixes #1350

If I'm doing it wrong, please point it out to me.

@S-mishina S-mishina changed the title support WarmupDurationSecs support istio Destination Dule WarmupDurationSecs Oct 15, 2023
@S-mishina S-mishina changed the title support istio Destination Dule WarmupDurationSecs Support istio Destination Dule WarmupDurationSecs Oct 15, 2023
@S-mishina S-mishina marked this pull request as ready for review October 15, 2023 10:28
aryan9600
aryan9600 reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for opening this PR!

you also need to add the field in the LoadBalancerSettings struct in pkg/apis/istio/v1alpha3/destination_rule.go

artifacts/flagger/crd.yaml Outdated Show resolved Hide resolved
@S-mishina S-mishina force-pushed the feature/support-istio-destinationrule-warmupdurationsecs branch 2 times, most recently from 6a031f8 to b70287d Compare October 17, 2023 00:08
@S-mishina
Copy link
Contributor Author

@aryan9600

you also need to add the field in the LoadBalancerSettings struct in pkg/apis/istio/v1alpha3/destination_rule.go

Thanks for the review!
I have added it below, am I wrong?
link

aryan9600
aryan9600 reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found one minor nit. also could you please squash all your commits, rebase on top of main and then force push? thanks!

artifacts/flagger/crd.yaml Outdated Show resolved Hide resolved
@S-mishina
support WarmupDurationSecs
d196fae 
Signed-off-by: S-mishina <[email protected]>

Delete unwanted descriptions

Signed-off-by: S-mishina <[email protected]>

Add kustomize/base/flagger/crd.yaml WarmupDurationSecs field　

Signed-off-by: S-mishina <[email protected]>

fix warmupDurationSecs description

Signed-off-by: S-mishina <[email protected]>
@S-mishina S-mishina force-pushed the feature/support-istio-destinationrule-warmupdurationsecs branch from a5e94e9 to d196fae Compare October 17, 2023 12:50
aryan9600
aryan9600 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @S-mishina 🏅

@aryan9600 aryan9600 merged commit c5369e9 into fluxcd:main Oct 17, 2023
17 checks passed
@flaviomrjr
Copy link

Thanks @S-mishina!
This will help a lot!!! (:

@stefanprodan stefanprodan changed the title Support istio Destination Dule WarmupDurationSecs Support Istio Destination Rule WarmupDurationSecs Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryan9600 aryan9600 aryan9600 approved these changes

@stefanprodan stefanprodan Awaiting requested review from stefanprodan stefanprodan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for istio's warmupDurationSecs
3 participants
@S-mishina @flaviomrjr @aryan9600