-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Istio Destination Rule WarmupDurationSecs #1540
Support Istio Destination Rule WarmupDurationSecs #1540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for opening this PR!
you also need to add the field in the LoadBalancerSettings
struct in pkg/apis/istio/v1alpha3/destination_rule.go
6a031f8
to
b70287d
Compare
Thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found one minor nit. also could you please squash all your commits, rebase on top of main and then force push? thanks!
Signed-off-by: S-mishina <[email protected]> Delete unwanted descriptions Signed-off-by: S-mishina <[email protected]> Add kustomize/base/flagger/crd.yaml WarmupDurationSecs field Signed-off-by: S-mishina <[email protected]> fix warmupDurationSecs description Signed-off-by: S-mishina <[email protected]>
a5e94e9
to
d196fae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @S-mishina 🏅
Thanks @S-mishina! |
Fixes #1350
If I'm doing it wrong, please point it out to me.