Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selective excluding secrets/configmaps from cloning #435

Closed
voroniys opened this issue Feb 11, 2020 · 1 comment · Fixed by #671
Closed

Selective excluding secrets/configmaps from cloning #435

voroniys opened this issue Feb 11, 2020 · 1 comment · Fixed by #671
Labels
kind/feature Feature request

Comments

@voroniys
Copy link

Initially requested in #417 - make possible to exclude some secret or configmap from cloning to -primary and -cannary. To my mind the best way to achieve it is place some special annotation to secret/configmap that should not be cloned.
The configuration switch introduced in #425 can work as setting default policy, so tracking by default yes or no, which in turn can be altered for specified resources with annotation set to true or false.
This will be complete and ideal solution for issue #417
@stefanprodan stefanprodan added the kind/feature Feature request label Feb 11, 2020
stealthybox added a commit to stealthybox/flagger that referenced this issue Aug 14, 2020
@stealthybox
Support per-config configTracker disable via ConfigMap/Secret annotation
669c2d2 
This allows a user to annotate a specific ConfigMap or Secret to be disabled/ignored via the
configTracking logic that tracks config changes makes configuration copies for the primary Deploy

Closes fluxcd#435
@stealthybox stealthybox mentioned this issue Aug 14, 2020
Merged
stealthybox added a commit to stealthybox/flagger that referenced this issue Aug 14, 2020
@stealthybox
Support per-config configTracker disable via ConfigMap/Secret annotation
fccdef3 
This allows a user to annotate a specific ConfigMap or Secret to be disabled/ignored via the
configTracking logic that tracks config changes makes configuration copies for the primary Deploy

Closes fluxcd#435
stealthybox added a commit to stealthybox/flagger that referenced this issue Aug 17, 2020
@stealthybox
Support per-config configTracker disable via ConfigMap/Secret annotation
9ada1d3 
This allows a user to annotate a specific ConfigMap or Secret to be disabled/ignored via the
configTracking logic that tracks config changes makes configuration copies for the primary Deploy

Closes fluxcd#435
stealthybox added a commit to stealthybox/flagger that referenced this issue Aug 17, 2020
@stealthybox
Support per-config configTracker disable via ConfigMap/Secret annotation
dad70a6 
This allows a user to annotate a specific ConfigMap or Secret to be disabled/ignored via the
configTracking logic that tracks config changes makes configuration copies for the primary Deploy

Closes fluxcd#435
@stealthybox
Copy link
Member

@voroniys, this is now included in the latest release -- we hope it satisfies your use-case 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support per-config configTracker disable via ConfigMap/Secret annotation stealthybox/flagger
3 participants
@voroniys @stealthybox @stefanprodan