Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for queryParams in canary match condition #880

Closed
abhijitchaudhari1 opened this issue Apr 8, 2021 · 3 comments · Fixed by #1505
Closed

Support for queryParams in canary match condition #880

abhijitchaudhari1 opened this issue Apr 8, 2021 · 3 comments · Fixed by #1505
Labels
help wanted Extra attention is needed kind/feature Feature request

Comments

@abhijitchaudhari1
Copy link

Currently A/B testing canary match condition only supports headers and cookies. Can we add support for queryParams as well.

I have a use case where websocket connection is setting query parameter not header.

Istio does support the queryParams but not able to use effectively with flagger for AB testing.

image
@abhijitchaudhari1
Copy link
Author

@stefanprodan please check this.

@stefanprodan stefanprodan added help wanted Extra attention is needed kind/feature Feature request labels Apr 13, 2021
@abhijitchaudhari1
Copy link
Author

any update on this ?

sonbui00 added a commit to sonbui00/flagger that referenced this issue Sep 5, 2023
@sonbui00
fix: Support for queryParams in canary match condition fluxcd#880
d822649 
Signed-off-by: Son Bui <[email protected]>
sonbui00 added a commit to sonbui00/flagger that referenced this issue Sep 5, 2023
@sonbui00
fix: Support for queryParams in canary match condition fluxcd#880
766a047 
Signed-off-by: Son Bui <[email protected]>
@sonbui00 sonbui00 mentioned this issue Sep 5, 2023
Merged
sonbui00 added a commit to sonbui00/flagger that referenced this issue Sep 7, 2023
@sonbui00
fix: Support for queryParams in canary match condition fluxcd#880
ff25d1e 
Signed-off-by: Son Bui <[email protected]>
aryan9600 added a commit that referenced this issue Sep 7, 2023
@aryan9600
Merge pull request #1505 from sonbui00/fix-880
8dbd8d5 
fix: Support for queryParams in canary match condition #880
S-mishina pushed a commit to S-mishina/flagger that referenced this issue Oct 15, 2023
@sonbui00 @S-mishina
fix: Support for queryParams in canary match condition fluxcd#880
1696581 
Signed-off-by: Son Bui <[email protected]>
@g-traveller
Copy link

does it support right now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed kind/feature Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Support for queryParams in canary match condition #880 sonbui00/flagger
3 participants
@stefanprodan @abhijitchaudhari1 @g-traveller