-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add canary analysis result as Prometheus metrics #1148
Add canary analysis result as Prometheus metrics #1148
Conversation
Signed-off-by: Ying Liu <[email protected]>
Co-authored-by: Stefan Prodan <[email protected]> Signed-off-by: Ying Liu <[email protected]>
c34cd92
to
1348332
Compare
Codecov Report
@@ Coverage Diff @@
## main #1148 +/- ##
==========================================
- Coverage 57.29% 56.78% -0.51%
==========================================
Files 78 79 +1
Lines 6343 6611 +268
==========================================
+ Hits 3634 3754 +120
- Misses 2166 2301 +135
- Partials 543 556 +13
Continue to review full report at Codecov.
|
@stefanprodan , updated the PR for the suggested changes. Can you help to review again? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add these metrics to docs here: https://github.com/fluxcd/flagger/blob/main/docs/gitbook/usage/monitoring.md#metrics
Signed-off-by: Ying Liu <[email protected]>
@stefanprodan , updated the PR for the suggested changes. Can you help to review again? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @cdlliuy 🏅
Fix of #1147
With this code changes, in my demo case, I can get the following metrics:
Let me know if there are any testcase are required.