-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gloo): Use correct route table name in case service name was overwritten #1300
fix(gloo): Use correct route table name in case service name was overwritten #1300
Conversation
…written Signed-off-by: mdolinin <[email protected]>
563a82c
to
4c0b2be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdolinin can you please bump Gloo Helm chart version to latest in e2e tests here: https://github.com/fluxcd/flagger/blob/main/test/gloo/install.sh#L5
Signed-off-by: mdolinin <[email protected]>
@stefanprodan Updated to the latest stable |
…from >1.12.x Signed-off-by: mdolinin <[email protected]>
@stefanprodan can you please approve CI workflow to execute. I have made necessary change to test. And updated PR description. Thanks. |
@stefanprodan Can we re-run [e2e-test (nginx)] (https://github.com/fluxcd/flagger/actions/runs/3322155362/jobs/5490871791#logs)? I could not understood how my last commit impacted that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @mdolinin 🏅
Steps to reproduce bug:
Canary
resource withservice.name
set and providergloo
For example:
RouteTable
with namepodinfo-flagger
query error: routetables.gateway.solo.io
for namepodinfo
This PR will use same func and names for
GetRoutes
as forReconcile
.PR contains:
1.12.31
gateway
deployment in tests. Because gateway functionality is removed from a standalone pod, and is now included in the Gloo Edge control plane pod. https://docs.solo.io/gloo-edge/latest/operations/upgrading/v1.12/