Run confirm-rollout
checks only before scaling up deployment
#1414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
confirm-rollout
webhook is called on every canary run, regardless of its phase. This PR changes the scheduler to run it only when a canary run is triggered and right before the canary deployment is scaled up. Furthermore, the webhook is now called with the current phase of the canary instead ofProgressing
regardless of the actual phase.