Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gatewayapi: add support for session affinity #1507

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Conversation

aryan9600
Copy link
Member

Add support for Canary releases with session affinity for Gateway API. This enables any Gateway API implementation that supports ResponseHeaderModifier to be used with session affinity.

For more info, see https://docs.flagger.app/usage/deployment-strategies#canary-release-with-session-affinity

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Patch coverage: 84.56% and project coverage change: +0.94% 🎉

Comparison is base (8dbd8d5) 54.33% compared to head (0eaf054) 55.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1507      +/-   ##
==========================================
+ Coverage   54.33%   55.28%   +0.94%     
==========================================
  Files          85       85              
  Lines       10186    10233      +47     
==========================================
+ Hits         5535     5657     +122     
+ Misses       3996     3917      -79     
- Partials      655      659       +4     
Files Changed Coverage Δ
pkg/canary/deployment_controller.go 57.05% <ø> (+12.66%) ⬆️
pkg/router/gateway_api_v1beta1.go 55.78% <84.56%> (+15.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @aryan9600 🥇

Add support for Canary releases with session affinity for Gateway API.
This enables any Gateway API implementation that supports
[`ResponseHeaderModifier`](https://github.com/kubernetes-sigs/gateway-api/blob/3d22aa5a08413222cb79e6b2e245870360434614/apis/v1beta1/httproute_types.go#L651)
to be used with session affinity.

Signed-off-by: Sanskar Jaiswal <[email protected]>
@aryan9600 aryan9600 merged commit 7ab0eb1 into main Sep 11, 2023
17 checks passed
@aryan9600 aryan9600 deleted the gw-session-affinity branch September 11, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants