-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gatewayapi: add support for session affinity #1507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1507 +/- ##
==========================================
+ Coverage 54.33% 55.28% +0.94%
==========================================
Files 85 85
Lines 10186 10233 +47
==========================================
+ Hits 5535 5657 +122
+ Misses 3996 3917 -79
- Partials 655 659 +4
☔ View full report in Codecov by Sentry. |
aryan9600
force-pushed
the
gw-session-affinity
branch
from
September 8, 2023 12:04
d58cb1a
to
ff1508d
Compare
stefanprodan
reviewed
Sep 8, 2023
aryan9600
force-pushed
the
gw-session-affinity
branch
from
September 8, 2023 12:39
ff1508d
to
faa32b2
Compare
stefanprodan
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @aryan9600 🥇
Add support for Canary releases with session affinity for Gateway API. This enables any Gateway API implementation that supports [`ResponseHeaderModifier`](https://github.com/kubernetes-sigs/gateway-api/blob/3d22aa5a08413222cb79e6b2e245870360434614/apis/v1beta1/httproute_types.go#L651) to be used with session affinity. Signed-off-by: Sanskar Jaiswal <[email protected]>
Signed-off-by: Sanskar Jaiswal <[email protected]>
Signed-off-by: Sanskar Jaiswal <[email protected]>
aryan9600
force-pushed
the
gw-session-affinity
branch
from
September 11, 2023 08:27
faa32b2
to
0eaf054
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Canary releases with session affinity for Gateway API. This enables any Gateway API implementation that supports
ResponseHeaderModifier
to be used with session affinity.For more info, see https://docs.flagger.app/usage/deployment-strategies#canary-release-with-session-affinity