You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add threadiness as an option to the helm chart to increase the value beyond the default of 2 threads. Bump chart version to 1.1.0 to reflect the new chart feature.
@mvollman changing the number of workers doesn't make any difference, Flagger has its own scheduling mechanism, each canary gets a dedicated go routine.
We have currently increased threadiness for performance reasons in both of our k8s clusters. I set it manually before forking the helm chart. Once we got the responsiveness we wanted from the operator I tried setting threadiness back to the default and saw the length of time between canary steps increase. I don't have good data to share, but I will try setting it back to the default and gathering some timings.
It is in fact the exact same issue. I am looking into the rate limiting now. I will collect some more data around timings. The rate limiting makes sense, but I did also see an improvement with the threadiness increase.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mvollman
force-pushed
the
helm_threadiness
branch
from
Add threadiness as an option to the helm chart to increase the value beyond the default of 2 threads. Bump chart version to 1.1.0 to reflect the new chart feature.