Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORS policy support #83

Merged
merged 6 commits into from
Mar 6, 2019
Merged

Add CORS policy support #83

merged 6 commits into from
Mar 6, 2019

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Mar 6, 2019

This PR allows cross-origin resource sharing policy to be specified in the Canary service spec.

apiVersion: flagger.app/v1alpha3
kind: Canary
spec:
  service:
    port: 9898
    corsPolicy:
      allowOrigin:
        - example.com
      allowMethods:
        - GET
      allowCredentials: false
      allowHeaders:
        - x-some-header
      maxAge: 24h

Fix: #58

@codecov-io
Copy link

codecov-io commented Mar 6, 2019

Codecov Report

Merging #83 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #83      +/-   ##
=========================================
+ Coverage   54.74%   54.8%   +0.05%     
=========================================
  Files          13      13              
  Lines        1538    1540       +2     
=========================================
+ Hits          842     844       +2     
  Misses        556     556              
  Partials      140     140
Impacted Files Coverage Δ
pkg/router/istio.go 81.08% <100%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3a4201...41e839a. Read the comment docs.

@stefanprodan stefanprodan merged commit 4f1abd0 into master Mar 6, 2019
@stefanprodan stefanprodan deleted the cors-policy branch March 6, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants