Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling cross-namespace references #2337

Closed
6 tasks done
Tracked by #2308
stefanprodan opened this issue Jan 25, 2022 · 3 comments
Closed
6 tasks done
Tracked by #2308

Allow disabling cross-namespace references #2337

stefanprodan opened this issue Jan 25, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@stefanprodan
Copy link
Member

stefanprodan commented Jan 25, 2022

Given that RFC-0002 and RFC-0003 need more debating, I propose we add a boolean flag --no-cross-namespace-refs to all controllers so that users can disable cross-namespace references if they wish to do so.

This applies to:

  • GitRepository, Bucket and HelmRepository references in Kustomizations and HelmReleases
  • ImageRepository references in ImagePolicies
  • GitRepository references in ImageUpdateAutomations
  • Kustomization, HelmRelease, image and source references in Alerts

Flag spec:

flag.BoolVar(&noCrossNamespaceRefs, "no-cross-namespace-refs", false,
	"When set to true, references between custom resources are allowed " +
	"only if the reference and the referee are in the same namespace.")

Components:

  • fluxcd/pkg/runtime
  • kustomize-controller
  • helm-controller
  • notification-controller
  • image-reflector-controller
  • image-automation-controller
@squaremo
Copy link
Member

👍 I think this is sensible, and has a use even if/when ACLs are also implemented in the same controllers.

@makkes
Copy link
Member

makkes commented Jan 27, 2022

I like the idea!

@stefanprodan
Copy link
Member Author

Thanks @somtochiama and @squaremo for helping out implementing this on such short notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants