Allow disabling cross-namespace event sources #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
added
enhancement
stefanprodan
force-pushed
the
no-cross-namespace-refs
branch
4 times, most recently
from
4d8b20d
to
b85e902
Compare
somtochiama
reviewed
Jan 28, 2022
stefanprodan
force-pushed
the
no-cross-namespace-refs
branch
3 times, most recently
from
adefa11
to
50ad628
Compare
Introduce the flag `--no-cross-namespace-refs` (defaults to false) for allowing cluster admins to disable cross-namespace event sources for alerts. Signed-off-by: Stefan Prodan <[email protected]>
stefanprodan
force-pushed
the
no-cross-namespace-refs
branch
from
50ad628
to
44c08a2
Compare
somtochiama
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On multi-tenant clusters, platform admins can disable cross-namespace event sources with the
--no-cross-namespace-refs=trueflag. When this flag is set, alerts can only refer to event sources in the same namespace as the alert object, preventing tenants from subscribing to anther tenant's events.When the controller drops an event due to
--no-cross-namespace-refs=trueit logs:Part of: fluxcd/flux2#2337