Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to crypto/ssh for parsing of private keys #1404

Merged
merged 1 commit into from
May 10, 2021
Merged

Commits on May 10, 2021

  1. Switch to crypto/ssh for parsing of private keys

    This changes the logic for the parsing of private keys, as already
    done for the source-controller, so that it is able to recognize and
    work with a wider range of key formats instead of returning a vague
    error:
    
    ```console
    $ flux bootstrap git [..]
    ✗ ssh: this private key is passphrase protected
    ```
    
    A patch for this was already submitted and merged in `go-git/go-git`,
    but is not made available in a release yet:
    go-git/go-git#298
    
    Signed-off-by: Hidde Beydals <[email protected]>
    hiddeco committed May 10, 2021
    Configuration menu
    Copy the full SHA
    fbe7050 View commit details
    Browse the repository at this point in the history