Use Authorization header for Github PAT #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbeaumont
force-pushed
the
gh_auth
branch
from
59826eb
to
db66a66
Compare
|
Thanks for catching this! Then, please clean everything up that's referencing |
PATs are oauth tokens so there's no reason to use BasicAuth here. I read the GH docs as recommending `Authorization: Bearer` if possible. GH understands what kind of token is being used, e.g. I see: `Added on Aug 20, 2020 via personal access token owned by @michaelbeaumont` when I authenticate this way and add a DeployKey
michaelbeaumont
force-pushed
the
gh_auth
branch
from
db66a66
to
e49a1ae
Compare
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PATs are oauth tokens so there's no reason to use BasicAuth here.
I read the GH docs as recommending
Authorization: Bearerif possible.GH understands what kind of token is being used, e.g. I see:
Added on Aug 20, 2020 via personal access token owned by @michaelbeaumontwhen I authenticate this way and add a DeployKey
I left the interface as is but
WithPersonalAccessTokencould also just be removed.