Allow setting a default service account for impersonation #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the flag
--default-service-account
for allowing cluster admins to enforce impersonation across the cluster without having to use an admission controller.When the flag is set to a value that's not empty string, all HelmReleases which don't have
spec.serviceAccountName
specified will use the service account name provided by--default-service-account=<SA Name>
in the namespace of the object.Breaking changes:
--default-service-account=<SA name>
and/orspec.ServiceAccountName
are specified, the controller no longer queries the API to extract and use the SA token. Instead, the controller relies on the Kubernetes impersonation feature to run the reconciliation under thesystem:serviceaccount:<SA Namespace>:<SA Name>
identity. This impacts only clusters with custom made tokens andautomountServiceAccountToken
disabled. If a service account token points to a different identity (which should never be the case), then the controller will fail to reconcile withForbidden : User "system:serviceaccount:my-namespace:my-sa-name" cannot create resource
.spec.kubeConfig
andspec.ServiceAccountName
are specified, the controller will impersonate the service account on the target cluster, previously the controller ignored the service account.Part of: fluxcd/flux2#2340