Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the sprig functions library #223

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

souleb
Copy link
Member

@souleb souleb commented Sep 29, 2021

Adresses #160

All functions are not supported, The following are discarded:

	// Date functions
	"date",
	"date_in_zone",
	"date_modify",
	"now",
	"htmlDate",
	"htmlDateInZone",
	"dateInZone",
	"dateModify",

	// Strings
	"randAlphaNum",
	"randAlpha",
	"randAscii",
	"randNumeric",
	"uuidv4",

	// OS
	"env",
	"expandenv",

	// Network
	"getHostByName",

Commit message templating can use those functions

Signed-off-by: Soule BA [email protected]

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neatly done, thank you @souleb. I've made a couple of suggestions; see what you think, and if you're happier leaving things as they are, respond with a comment.

controllers/imageupdateautomation_controller.go Outdated Show resolved Hide resolved
controllers/imageupdateautomation_controller.go Outdated Show resolved Hide resolved
@squaremo
Copy link
Member

squaremo commented Sep 30, 2021

Additionally: first PR high-five ✋ !

@souleb souleb force-pushed the commit-template-funcs branch 5 times, most recently from c28f4ea to 3df2277 Compare October 1, 2021 17:23
@souleb
Copy link
Member Author

souleb commented Oct 12, 2021

@stefanprodan anything I can do to move this forward?

@squaremo
Copy link
Member

anything I can do to move this forward?

I think you have done all that's been asked of you 👍 You could rebase on main (removing the merge commit while you're at it), and I'll re-review, which would re-enable the merge button.

All functions are not supported, The following are discarded:
            // Date functions
            "date",
            "date_in_zone",
            "date_modify",
            "now",
            "htmlDate",
            "htmlDateInZone",
            "dateInZone",
            "dateModify",

            // Strings
            "randAlphaNum",
            "randAlpha",
            "randAscii",
            "randNumeric",
            "uuidv4",

            // OS
            "env",
            "expandenv",

            // Network
            "getHostByName",

Signed-off-by: Soule BA <[email protected]>
@souleb
Copy link
Member Author

souleb commented Oct 12, 2021

anything I can do to move this forward?

I think you have done all that's been asked of you 👍 You could rebase on main (removing the merge commit while you're at it), and I'll re-review, which would re-enable the merge button.

thanks @squaremo. Done!

@squaremo squaremo merged commit 674f833 into fluxcd:main Oct 12, 2021
@souleb souleb deleted the commit-template-funcs branch October 12, 2021 10:45
@squaremo
Copy link
Member

This will make lots of users happy, thank you @souleb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants