Respect PKG_CONFIG_PATH from the environment #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If brew (or some other installation method) has put openssl in a non-traditional place, you need to add that place to `PKG_CONFIG_PATH`; but, the Makefile effectively resets it when calling anything that uses it. So: - include any existing $PKG_CONFIG_PATH in invocations - document when and how to set PKG_CONFIG_PATH Signed-off-by: Michael Bridgen <[email protected]>
hiddeco
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If brew (or some other installation method) has put openssl.pc in a non-traditional place, you need to add that place to
PKG_CONFIG_PATH; but, the Makefile effectively resets it when calling anything that uses it.So:
Note: this doesn't appear to be necessary for source-controller. Hidde and I think this may be because git2go is a direct dependency there, whereas it's required via source-controller/pkg here -- why that matters is not clear :-/