Pass context to libgit2.RemoteCallbacks #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
force-pushed
the
libgit2-timeout
branch
from
9d8e11d
to
cbbb843
Compare
This was referenced Nov 1, 2021
Closed
darkowlzz
force-pushed
the
libgit2-timeout
branch
from
cbbb843
to
707e03d
Compare
Pass cancellable context to libgit2.RemoteCallbacks to be able to cancel the remote operations when the context is cancelled. For git clone, fetch and push, a context is created with the timeout of the target GitRepository. Signed-off-by: Sunny <[email protected]>
darkowlzz
force-pushed
the
libgit2-timeout
branch
from
707e03d
to
b299a9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass cancellable context to libgit2.RemoteCallbacks to be able to cancel
the remote operations when the context is cancelled.
For git clone, the context is created with the timeout specified in the target
GitRepository.
Based on the source-controller changes in fluxcd/source-controller#477.