Replace strings.TrimRight with strings.TrimSuffix #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrimRight was not correctly used. It takes a set of characters as the second argument and any chars matching the set on the right side of the string would be trimmed. TrimSuffix does exactly what I originally intended. Signed-off-by: Aurel Canciu <[email protected]>
hiddeco
approved these changes
Nov 11, 2021
|
We need to do a release ASAP, IAC is broken for all users right? |
|
Only for some (not-so-)edge cases, I think it can be affecting a lot of users. |
|
Think as a follow up, it would be neat if we can add a test to ensure we do not reintroduce the bug again. As apparently the current tests do not cover properly for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TrimRight was not correctly used. It takes a set of characters as the
second argument and any chars matching the set on the right side of the
string would be trimmed. TrimSuffix does exactly what I originally
intended.
Fixes #261