Remove direct dependency to go-git #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paulo Gomes <[email protected]>
stefanprodan
approved these changes
Mar 4, 2022
pjbgf
pushed a commit
to pjbgf/image-automation-controller
that referenced
this pull request
Mar 23, 2022
Changes replacing go-git with git2go introduced a bug in which pushes into new branches squashes all commits into one. xref: fluxcd#324 Signed-off-by: Paulo Gomes <[email protected]>
pjbgf
pushed a commit
to pjbgf/image-automation-controller
that referenced
this pull request
Mar 23, 2022
Changes replacing go-git with git2go introduced a bug in which pushes into new branches squashes all commits into one. xref: fluxcd#324 Signed-off-by: Paulo Gomes <[email protected]>
pjbgf
pushed a commit
to pjbgf/image-automation-controller
that referenced
this pull request
Mar 23, 2022
Changes replacing go-git with git2go introduced a bug in which pushes into new branches squashes all commits into one. xref: fluxcd#324 Signed-off-by: Paulo Gomes <[email protected]>
hiddeco
pushed a commit
to pjbgf/image-automation-controller
that referenced
this pull request
Mar 23, 2022
Changes replacing go-git with git2go introduced a bug in which pushes into new branches squashes all commits into one. xref: fluxcd#324 Signed-off-by: Paulo Gomes <[email protected]>
pjbgf
pushed a commit
to pjbgf/image-automation-controller
that referenced
this pull request
Mar 23, 2022
Changes replacing go-git with git2go introduced a bug in which pushes into new branches squashes all commits into one. xref: fluxcd#324 Signed-off-by: Paulo Gomes <[email protected]>
pjbgf
pushed a commit
to pjbgf/image-automation-controller
that referenced
this pull request
Mar 23, 2022
Changes replacing go-git with git2go introduced a bug in which pushes into new branches squashes all commits into one. xref: fluxcd#324 Signed-off-by: Paulo Gomes <[email protected]>
souleb
pushed a commit
to souleb/image-automation-controller
that referenced
this pull request
Mar 12, 2024
Changes replacing go-git with git2go introduced a bug in which pushes into new branches squashes all commits into one. xref: fluxcd#324 Signed-off-by: Paulo Gomes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates the use of
libgit2for all operations done by the controller.Context on tests
Given the the connection issues documented and reported, I did a long run on this PR to ensure this won't make matters worse.
This has been tested for over 24h in a patchy network and it seems to be causing slightly less errors when cloning git repositories. In such environment I tend to get one of the following error messages every 1-3 hours:
With this version the errors seem to have decrease in frequency to once every 6-7 hours. The range of errors seem to also have decreased:
Fixes #323