Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decommission libgit2 Unmanaged Transport #412

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Decommission libgit2 Unmanaged Transport #412

merged 2 commits into from
Aug 9, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Aug 9, 2022 •
edited
Loading

Decomissions libgit2 Unmanaged Transport and updates the dependencies below:

  • k8s.io/api to version 0.24.3.
  • k8s.io/apimachinery to version 0.24.3.
  • k8s.io/client-go to version 0.24.3.
  • github.com/fluxcd/image-reflector-controller/api to version 0.20.0.
  • github.com/fluxcd/source-controller to version 0.26.0.
  • k8s.io/kube-openapi to version v0.0.0-20220803164354-a70c9af30aea.
  • github.com/ProtonMail/go-crypto to version v0.0.0-20220730123233-d6ffb7692adf.
  • sigs.k8s.io/kustomize/kyaml to version v0.13.9.

Update dependencies
e3c7aef 
- k8s.io/api to version 0.24.3.
- k8s.io/apimachinery to version 0.24.3.
- k8s.io/client-go to version 0.24.3.
- github.com/fluxcd/image-reflector-controller/api to version 0.20.0.
- github.com/fluxcd/source-controller to version 0.26.0.
- k8s.io/* to version v0.24.3.
- k8s.io/kube-openapi to version v0.0.0-20220803164354-a70c9af30aea.
- github.com/ProtonMail/go-crypto to version v0.0.0-20220730123233-d6ffb7692adf.
- sigs.k8s.io/kustomize/kyaml to version v0.13.9.

Signed-off-by: Paulo Gomes <[email protected]>
@pjbgf pjbgf changed the title Update dependencies Decommission libgit2 Unmanaged Transport Aug 9, 2022
stefanprodan
stefanprodan approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @pjbgf

@pjbgf pjbgf mentioned this pull request Aug 9, 2022
Merged
@pjbgf pjbgf added this to the GA milestone Aug 9, 2022
aryan9600
aryan9600 requested changes Aug 9, 2022
View reviewed changes
Copy link
Member

@aryan9600 aryan9600 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ImageUpdateAutomationReconciler needs to be updated to have Libgit2TransportInitialized as a field (ref: https://github.com/fluxcd/source-controller/blob/v0.26.0/controllers/gitrepository_controller.go#L120) and the reconcile logic needs to verify whether libgit2 transports have been initialized before performing any git operations.

The GitManagedTransport feature needs to be removed from internal/features/features.go

@pjbgf
Copy link
Member Author

pjbgf commented Aug 9, 2022

@aryan9600 just removed GitManagedTransport, thanks for pointing it out.

For Libgit2TransportInitialized as currently the controller only supports libgit2 this PR exits early in main.go if it can't initialise libgit2. We can review this approach once we all git implementation code is in fluxcd/pkg.

@pjbgf
Copy link
Member Author

pjbgf commented Aug 9, 2022

This has been tested against GitHub, GitLab and BitBucket. All worked as expected.

@pjbgf pjbgf merged commit 88fec8e into fluxcd:main Aug 9, 2022
@pjbgf pjbgf deleted the update-deps branch August 9, 2022 14:30
@pjbgf pjbgf mentioned this pull request Aug 16, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryan9600 aryan9600 aryan9600 requested changes

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Maintainers' Focus
Status: Done
Milestone
GA
Development

Successfully merging this pull request may close these issues.
3 participants
@pjbgf @stefanprodan @aryan9600