Remove dependence on kustomize/setters2 #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package setters2 has been removed from kustomize: kubernetes-sigs/kustomize#5291 This commit removes the need to import setters2, by reproducing the last link with that code, which is a minor parsing helper. I have not changed the comment explaining what was changed from the original, since it's still accurate. The parsing func is a buried detail. Signed-off-by: Michael Bridgen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package setters2 has been removed from kustomize: kubernetes-sigs/kustomize#5291
This commit removes the need to import setters2, by reproducing the last link with that code, which is a minor parsing helper.
I have not changed the comment explaining what was changed from the original, since it's still accurate. The parsing func is a buried detail.