Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect use of format strings with the conditions package. #711

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fix incorrect use of format strings with the conditions package. #711

merged 1 commit into from
Jul 12, 2024

Commits on Jul 12, 2024

  1. Fix incorrect use of format strings with the conditions package. 

    The `Mark…` functions in the `conditions` package accept a format string and
(optional) arguments, just like `fmt.Printf` and friends.

In many places, the code passed an error message as the format string, causing
it to be interpreted as a format string by the `fmt` package. This leads to
issues when the message contains percent signs, e.g. URL-encoded values.

This PR adds a format string and shortens `err.Error()` to `err`, which yields
the same output.

This change is identical in principle to fluxcd/source-controller#1529.

Signed-off-by: Florian Forster <[email protected]>
    @octo
    octo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    25730b1 View commit details
    Browse the repository at this point in the history