Unit tests for event forwarding #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some scaffolding for testing that events are forwarded as specified by alerts. The controllers themselves aren't needed; but since the internal/server package refer directly to Kubernetes resources, the tests share prerequisites with controller tests. For that reason I have started by putting these tests in controllers/. I have tried not to touch the server code itself, but it was necessary to change it to use a fresh http.ServerMux rather than the (global) default, so that the tests can create an event server each. Signed-off-by: Michael Bridgen <[email protected]>
This rearranges the tests a little to make it easier to test for events being filtered (not forwarded). Signed-off-by: Michael Bridgen <[email protected]>
This adds tests that the filtering by alert.Spec.ExclusionList works. Signed-off-by: Michael Bridgen <[email protected]>
`continue` with a label is for exactly this situation. Signed-off-by: Michael Bridgen <[email protected]>
Signed-off-by: Michael Bridgen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some tests to check that events are forwarded as specified by alerts.
The controllers themselves aren't needed; but since the internal/server package refer directly to Kubernetes resources, the tests share prerequisites with controller tests. For that reason I have started by putting these tests in controllers/.
I have tried not to touch the server code itself, but it was necessary to change it to use a fresh http.ServerMux rather than the (global) default, so that the tests can create an event server each.
I've taken the opportunity to include a very minor tidy of bits of internal/server/.